Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][schema]Improve the getSchema() method in SchemaRegistryServiceImpl.java #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nikam14
Copy link
Owner

@nikam14 nikam14 commented Sep 24, 2024

Motivation

In SchemaRegistryServiceImpl.java there are two getSchema() methods.
1 - getSchema(String schemaId)
2 - getSchema(String schemaId, SchemaVersion version)
In the first method after getting Schema it is checked that whether the Schema is deleted or not. In Second method it is not checked when Schema.version=Latest .
Adding the check can improve code.

Modifications

checking Schema is deleted or not before return in getSchema() method.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant